Skip to content

Conversation

@andrinoff
Copy link

Pull Request

What? (description)

This pull requests includes a new workflow, which will do everything update.sh did, just automatically, while also creating a pull request to the repository.

Why? (reasoning)

This simplifies the process of maintaining the Sidero Labs tap, and was requested in #2148, #12608.

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

Additional notes

This workflow requires a new secret HOMEBREW_TAP_TOKEN, which is a GitHub PAT of any user with permissions to create commits in the siderolabs/homebrew-tap repository.

This workflow can also be used in the siderolabs/omni with small changes required.

@github-project-automation github-project-automation bot moved this to To Do in Planning Jan 27, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning Jan 27, 2026
@rothgar
Copy link
Member

rothgar commented Jan 27, 2026

This is great! Thanks for the PR.

There is a homebrew command for bumping versions which might be more reliable and easier to use. It's called bump-formula-pr and you can read about it here https://docs.brew.sh/Manpage#bump-formula-pr-options-formula It should do a lot of this manual version changes automatically.

We also have a "meta" packages called sidero-tools which needs to be bumped when we make a release. You can see the forumla here https://github.com/siderolabs/homebrew-tap/blob/main/Formula/sidero-tools.rb and the only thing that needs to change is the version number. This lets people automatically try and fetch the latest version of our other tools.

@andrinoff
Copy link
Author

We also have a "meta" packages called sidero-tools which needs to be bumped when we make a release. You can see the forumla here siderolabs/homebrew-tap@main/Formula/sidero-tools.rb and the only thing that needs to change is the version number. This lets people automatically try and fetch the latest version of our other tools.

the version needs to be the same as talosctl? just saw that it was on v1.1.0, so supposed that it is something else

@andrinoff
Copy link
Author

There is a homebrew command for bumping versions which might be more reliable and easier to use. It's called bump-formula-pr and you can read about it here docs.brew.sh/Manpage#bump-formula-pr-options-formula It should do a lot of this manual version changes automatically.

I'll have to test this, but i'm pretty sure this won't work

@andrinoff
Copy link
Author

andrinoff commented Jan 27, 2026

There is a homebrew command for bumping versions which might be more reliable and easier to use. It's called bump-formula-pr and you can read about it here docs.brew.sh/Manpage#bump-formula-pr-options-formula It should do a lot of this manual version changes automatically.

I'll have to test this, but i'm pretty sure this won't work

as i said, this results in an error

Error: inreplace failed
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/siderolabs/homebrew-tap/Formula/talosctl.rb:
  expected replacement of /https:\/\/github\.com\/siderolabs\/talos\/releases\/download\/v1\.12\.1\/talosctl\-linux\-amd64/ with "https://github.com/siderolabs/talos/releases/download/v1.12.2/talosctl-linux-amd64"

this is due to the file having the version as a variable:

url "https://github.com/siderolabs/talos/releases/download/v#{version}/talosctl-darwin-arm64"

and not plain text, i.e.

url "https://github.com/siderolabs/talos/releases/download/v1.12.1/talosctl-darwin-arm64",

This is 1 of the issues.

Also, I am not sure it would keep on going to replace for every architecture and OS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants