feat: add LVM status controller

[shanduur]

Add resource types for physical volumes, volume groups, and logical
volumes to track LVM inventory and state. Provides read-only discovery
through the resource API for visibility into existing LVM setup.

Manual Testing

Creating LVM objects:

cat <<'EOF' | sudo -E _out/talosctl-linux-amd64 -n 172.20.0.6 debug docker.io/library/alpine:latest --args /bin/sh
set -e

NSENTER="nsenter --target 1 --mount --uts --ipc --net --pid"

echo "==> Creating PVs"
$NSENTER pvcreate -y /dev/vdb /dev/vdc /dev/vdd

echo "==> Creating VG"
$NSENTER vgcreate vgdata /dev/vdb /dev/vdc /dev/vdd

echo "==> Creating LV"
$NSENTER lvcreate -n lvdata -l 100%FREE vgdata

echo "==> Listing LVM state"
$NSENTER pvs
$NSENTER vgs
$NSENTER lvs
EOF

Removing LVM objects:

cat <<'EOF' | sudo -E _out/talosctl-linux-amd64 -n 172.20.0.6 debug docker.io/library/alpine:latest --args /bin/sh
set -e

NSENTER="nsenter --target 1 --mount --uts --ipc --net --pid"

echo "==> Removing logical volume"
$NSENTER lvremove -y /dev/vgdata/lvdata || true

echo "==> Removing volume group"
$NSENTER vgremove -y vgdata || true

echo "==> Wiping physical volumes"
$NSENTER pvremove -y /dev/vdb /dev/vdc /dev/vdd || true

echo "==> Done"
$NSENTER pvs || true
$NSENTER vgs || true
$NSENTER lvs || true
EOF

Signed-off-by: Mateusz Urbanek mateusz.urbanek@siderolabs.com

[Copilot]

Pull request overview

Adds three new read-only resources (LVMPhysicalVolumeStatus, LVMVolumeGroupStatus, LVMLogicalVolumeStatus) and corresponding controllers that periodically scan host LVM state via lvm pvs/vgs/lvs --reportformat json. Refactors the existing block.LVMActivationController into a new storage package backed by a shared internal/pkg/lvm helper, moves the TestLVMActivation integration test into a new StorageSuite, and adds a TestLVMStatus integration test. Includes generated proto/deep-copy/docs updates.

Changes:

• New internal/pkg/lvm package wrapping lvm CLI (PV/VG/LV listing, vgchange, pvscan).
• New storage resource types (machinery + proto + docs) and three polling controllers (30s interval).
• Moves LVMActivationController from block to storage, threading the shared *lvm.LVM helper.

Reviewed changes

Copilot reviewed 30 out of 33 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/pkg/lvm/{lvm,pv,vg,lv,activate}.go	New helper wrapping lvm binary, JSON report decoding, udev parsing.
internal/pkg/lvm/lvm_test.go + testdata/*	Unit tests covering pvs/vgs/lvs JSON parsing and Tags unmarshalling.
pkg/machinery/resources/storage/*.go	New LVMPhysicalVolumeStatus / LVMVolumeGroupStatus / LVMLogicalVolumeStatus resources, deep-copy, registration test.
pkg/machinery/api/resource/definitions/storage/storage.pb.go + api/.../storage.proto	Generated protobuf bindings for the new specs.
internal/app/machined/pkg/controllers/storage/*.go	New status controllers + relocated LVMActivationController.
internal/app/machined/pkg/runtime/v1alpha2/v1alpha2_{controller,state}.go	Wires new controllers and registers new resource types; constructs shared lvm.New().
internal/integration/api/{storage,volumes,selinux}.go	Adds StorageSuite with TestLVMStatus and relocated TestLVMActivation; expects /run/lock/lvm SELinux label.
website/content/v1.14/reference/api.md	Auto-generated API documentation for new specs.
hack/release.toml	Release note describing new LVM status resources.

Files not reviewed (2)

• pkg/machinery/api/resource/definitions/storage/storage.pb.go: Language not supported
• pkg/machinery/resources/storage/deep_copy.generated.go: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[smira]

we could probably actually use proper namespace name, it was a bug when I originally started block that I put it to the wrong namespace, but it was too late when I discovered it

[shanduur]

Fixed.

[smira]

how bad it is to poll on interval? would it e.g. wake up a sleeping disk just to check LVM metadata?

[shanduur]

pvs -a enumerates every block device so it will open each and read sector 0 / PV label region to check for LVM signature. On spun-down HDDs that wakes the disk every poll - so could probably significantly increase the wear of the device.

[shanduur]

I'll fix that.

[shanduur]

Dropped the polling.

[smira]

can a PV change without ever writing to blockdevice? we have a flow which goes into DiscoverdVolumes and it notifies on any process opening a blockdevice for write, we could feed it here?

(happy to discuss more)

[shanduur]

PV not, but some kernel DM states can - e.g. active/inactive, suspended, open-count, kernel major/minor - lives in device-mapper, not on disk. So thing slike lvchange -ay/-an, dmsetup suspend, mount/umount can flip these w/o touching PV metadata. Reflected in lv_active/lv_suspended/lv_device_open columns.

[smira]

but I guess that would trigger DM blockdevice changes? We also listen for these (we listen for all blockdevice events).

[smira]

I wonder if we should throttle this (the easiest way possible is to add something like this after this line):

This way we would coalesce multiple updates into a single event, as e.g. BlockDevice -> Disk -> DV will always propagate in a sequence

select {
case <-time.After(time.Second): // or something bigger
case <-ctx.Done():
  return nil
}

[shanduur]

/m