chore(ci): fix the job conditions#13370
Merged
Merged
Conversation
frezbo
added
integration/image-cache
There was a problem hiding this comment.
Pull request overview
This PR updates CI workflow generation so selected integration suites use job-level conditions and matrix jobs instead of per-step label checks and repeated sequential steps.
Changes:
- Converts Cilium, image-cache, and image-factory integration suites to matrices.
- Moves several generated CI label checks from step-level gates to job-level
ifconditions. - Updates generated artifact names to include matrix identifiers.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
.kres.yaml |
Adds matrix definitions for Cilium, image-cache, and image-factory jobs. |
.github/workflows/ci.yaml |
Regenerates CI with matrix jobs and job-level label conditions. |
.github/workflows/integration-cilium-triggered.yaml |
Converts triggered Cilium workflow to a matrix. |
.github/workflows/integration-image-cache-triggered.yaml |
Converts triggered image-cache workflow to a matrix. |
.github/workflows/integration-image-factory-triggered.yaml |
Converts triggered image-factory workflow to a matrix. |
Comments suppressed due to low confidence (2)
.github/workflows/ci.yaml:3333
- The generated condition no longer includes the
not-cancelledcondition that is still present in the Kres source for this job (.kres.yaml:1121-1122). That makes the checked-in workflow diverge from the source spec and changes the job'sneedssemantics; please either keep the generated!cancelled()or remove the condition from.kres.yamlso regeneration is consistent.
if: contains(fromJSON(needs.default.outputs.labels || '[]'), 'integration/misc') || contains(fromJSON(needs.default.outputs.labels || '[]'), 'integration/misc-3') || contains(fromJSON(needs.default.outputs.labels || '[]'), 'integration/release-gate')
.github/workflows/ci.yaml:3450
- The generated condition no longer includes the
not-cancelledcondition that is still present in the Kres source for this job (.kres.yaml:1199-1200). That makes the checked-in workflow diverge from the source spec and changes the job'sneedssemantics; please either keep the generated!cancelled()or remove the condition from.kres.yamlso regeneration is consistent.
if: contains(fromJSON(needs.default.outputs.labels || '[]'), 'integration/misc') || contains(fromJSON(needs.default.outputs.labels || '[]'), 'integration/misc-4') || contains(fromJSON(needs.default.outputs.labels || '[]'), 'integration/release-gate')
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frezbo
removed
integration/cilium
Fix the job conditions and drop per step check, which waste runners. Move more jobs to matrices. Signed-off-by: Noel Georgi <git@frezbo.dev>
Rotate AWS credentials as per policy. Signed-off-by: Noel Georgi <git@frezbo.dev>
smira
approved these changes
May 18, 2026
Member
Author
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the job conditions and drop per step check, which waste runners. Move more jobs to matrices.