Skip to content

feat: enable Flannel nftables mode#13376

Merged
talos-bot merged 1 commit into
siderolabs:mainfrom
smira:feat/flannel-nftables-native
May 18, 2026
Merged

feat: enable Flannel nftables mode#13376
talos-bot merged 1 commit into
siderolabs:mainfrom
smira:feat/flannel-nftables-native

Conversation

@smira
Copy link
Copy Markdown
Member

@smira smira commented May 18, 2026

Use native nftables (it uses nft CLI internally) instead of going via iptables-nft shim.

Copilot AI review requested due to automatic review settings May 18, 2026 12:14
@smira smira added the integration/conformance Run Kubernetes conformance tests (all variants) label May 18, 2026
@smira smira added the integration/provision Run provision integration tests (all tracks) label May 18, 2026
@github-project-automation github-project-automation Bot moved this to To Do in Planning May 18, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning May 18, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables Flannel’s native nftables mode in the Talos-managed Flannel ConfigMap and documents the behavior change for release notes.

Changes:

  • Adds EnableNFTables: true to generated Flannel net-conf.json.
  • Updates Flannel ConfigMap golden test fixtures for IPv4, IPv6, and dual-stack.
  • Adds a release note for the Flannel CNI behavior change.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/app/machined/pkg/controllers/k8s/internal/k8stemplates/flannel.go Adds EnableNFTables to the generated Flannel network config.
internal/app/machined/pkg/controllers/k8s/internal/k8stemplates/testdata/flannel-configmap-v4.yaml Updates IPv4 golden output.
internal/app/machined/pkg/controllers/k8s/internal/k8stemplates/testdata/flannel-configmap-v6.yaml Updates IPv6 golden output.
internal/app/machined/pkg/controllers/k8s/internal/k8stemplates/testdata/flannel-configmap-dual.yaml Updates dual-stack golden output.
hack/release.toml Documents the Flannel nftables mode change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread hack/release.toml Outdated
@github-project-automation github-project-automation Bot moved this from In Review to Approved in Planning May 18, 2026
Copy link
Copy Markdown
Member

@shanduur shanduur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

Use native nftables (it uses `nft` CLI internally) instead of going via
`iptables-nft` shim.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira smira removed integration/conformance Run Kubernetes conformance tests (all variants) integration/provision Run provision integration tests (all tracks) labels May 18, 2026
@smira smira force-pushed the feat/flannel-nftables-native branch from 458bea6 to ecb7d45 Compare May 18, 2026 15:07
@smira
Copy link
Copy Markdown
Member Author

smira commented May 18, 2026

/m

@talos-bot talos-bot merged commit ecb7d45 into siderolabs:main May 18, 2026
186 of 187 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Planning May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants