Skip to content

feat: add quirks for RegistryAuthConfig support#13378

Closed
Unix4ever wants to merge 1 commit into
siderolabs:mainfrom
Unix4ever:add-registry-config-quirks
Closed

feat: add quirks for RegistryAuthConfig support#13378
Unix4ever wants to merge 1 commit into
siderolabs:mainfrom
Unix4ever:add-registry-config-quirks

Conversation

@Unix4ever
Copy link
Copy Markdown
Member

Config is supported starting from Talos version 1.12.0.

Copilot AI review requested due to automatic review settings May 18, 2026 15:37
@github-project-automation github-project-automation Bot moved this to To Do in Planning May 18, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning May 18, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new imager quirk to detect whether a Talos version supports the RegistryAuthConfig multi-document config, matching the stated support threshold of Talos 1.12.0.

Changes:

  • Added SupportsRegistryAuthConfig() with a 1.12.0 minimum version.
  • Added unit coverage for unsupported, supported, prerelease, and unparsable/latest-version behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/machinery/imager/quirks/quirks.go Adds the RegistryAuthConfig support quirk.
pkg/machinery/imager/quirks/quirks_test.go Adds tests for the new quirk behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Config is supported starting from Talos version 1.12.0.

Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
@Unix4ever Unix4ever force-pushed the add-registry-config-quirks branch from ad8698e to e4caa75 Compare May 18, 2026 15:40
Copy link
Copy Markdown
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this, it's already gated with network multi-doc

if !in.Options.VersionContract.MultidocNetworkConfigSupported() {
// old-style registry config

But also you can't really do authenticated Image Factory without it, as it will not be able to do e.g. upgrade in maintenance mode without multi-doc

@Unix4ever
Copy link
Copy Markdown
Member Author

we don't need this, it's already gated with network multi-doc

if !in.Options.VersionContract.MultidocNetworkConfigSupported() {
// old-style registry config

But also you can't really do authenticated Image Factory without it, as it will not be able to do e.g. upgrade in maintenance mode without multi-doc

A bit confusing but alright. Easier for me actually :)

@Unix4ever Unix4ever closed this May 18, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Done in Planning May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants