feat: add quirks for RegistryAuthConfig support#13378
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new imager quirk to detect whether a Talos version supports the RegistryAuthConfig multi-document config, matching the stated support threshold of Talos 1.12.0.
Changes:
- Added
SupportsRegistryAuthConfig()with a 1.12.0 minimum version. - Added unit coverage for unsupported, supported, prerelease, and unparsable/latest-version behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pkg/machinery/imager/quirks/quirks.go |
Adds the RegistryAuthConfig support quirk. |
pkg/machinery/imager/quirks/quirks_test.go |
Adds tests for the new quirk behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Config is supported starting from Talos version 1.12.0. Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
ad8698e to
e4caa75
Compare
smira
left a comment
There was a problem hiding this comment.
we don't need this, it's already gated with network multi-doc
talos/pkg/machinery/config/generate/registry.go
Lines 21 to 22 in ecb7d45
But also you can't really do authenticated Image Factory without it, as it will not be able to do e.g. upgrade in maintenance mode without multi-doc
A bit confusing but alright. Easier for me actually :) |
Config is supported starting from Talos version 1.12.0.