Skip to content

Refactor RPC-based checks to use security_checks module#12

Open
ccronca wants to merge 1 commit into
sidhpurwala-huzaifa:mainfrom
ccronca:feature/refactor-rpc-checks-to-security-module
Open

Refactor RPC-based checks to use security_checks module#12
ccronca wants to merge 1 commit into
sidhpurwala-huzaifa:mainfrom
ccronca:feature/refactor-rpc-checks-to-security-module

Conversation

@ccronca

@ccronca ccronca commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Summary

Refactor RPC-based security checks to use shared security_checks module functions, enabling code reuse across all transports.

Motivation

Continue the refactoring effort from PR #10 to centralize security check logic for reuse across all transports.

Overview of changes

  • Migrate four RPC-based checks from inline implementations to security_checks module:
    • R-01: Resource traversal
    • R-02: Resource access control
    • X-02: Injection fuzzing
    • A-03: Token passthrough
  • Add parametrized unit tests for R-01 and R-02
  • Add unit tests for X-02 and A-03
  • Update integration test with status validation for all migrated checks
  • Document insecure server mode 0 behavior and add TODO for future mode-specific tests

Part of a series progressively moving security checks from HTTP-specific implementations into the shared security_checks module

🤖 This PR description was generated with AI assistance from Claude Code.

@ccronca ccronca force-pushed the feature/refactor-rpc-checks-to-security-module branch 2 times, most recently from 39d5907 to 42684dc Compare November 21, 2025 13:46
Migrate four RPC-based checks to use shared security_checks functions for reuse across transports.

Migrated checks:
- R-01: Resource traversal
- R-02: Resource access control
- X-02: Injection fuzzing
- A-03: Token passthrough

Changes:
- Add parametrized unit tests for R-01 and R-02
- Add unit tests for X-02 and A-03
- Update integration test with status validation for all checks
- Document test behavior against insecure server mode 0
- Add TODO for future mode-specific integration tests

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: ccronca <1499184+ccronca@users.noreply.github.com>
@ccronca ccronca force-pushed the feature/refactor-rpc-checks-to-security-module branch from 42684dc to a2717a6 Compare November 21, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant