CA Tool Telemetry #238
Closed
MalavikaKrishnan100 wants to merge 8 commits intofeature/app-settings-redesignfrom
Closed
CA Tool Telemetry #238MalavikaKrishnan100 wants to merge 8 commits intofeature/app-settings-redesignfrom
MalavikaKrishnan100 wants to merge 8 commits intofeature/app-settings-redesignfrom
Conversation
adityanarayanp
added
enhancement
| <ItemGroup> | ||
| <ProjectReference Include="..\LCT.Common\LCT.Common.csproj" /> | ||
| <ProjectReference Include="..\LCT.Services\LCT.Services.csproj" /> | ||
| <ProjectReference Include="..\TelemetryHelperClass\Telemetry.csproj" /> |
Collaborator
There was a problem hiding this comment.
Why do we have this telemetry helper class ?
| if (appSettings.Telemetry == true) | ||
| { | ||
| Logger.Warn( TelemetryConstant.StartLogMessage ); | ||
| Telemetry.Telemetry telemetry = new Telemetry.Telemetry("ApplicationInsights", new Dictionary<string, string> |
Collaborator
There was a problem hiding this comment.
Move this to a constant in the telementryconstant class
| public const string IdentifierKpiData = "IdentifierKpiDataTelemetry"; | ||
| public const string CreatorKpiData = "CreatorKpiDataTelemetry"; | ||
| public const string ArtifactoryUploaderKpiData = "UploaderKpiDataTelemetry"; | ||
| public const string StartLogMessage = "Telemetry for execution is now enabled and being tracked. You can disable it by using the command-line option --Telemetry=false."; |
Collaborator
There was a problem hiding this comment.
also mention that it can be disabled via the app settings
adityanarayanp
requested changes
Jan 24, 2025
Collaborator
adityanarayanp
left a comment
adityanarayanp
left a comment
There was a problem hiding this comment.
Please pull the latest changes from the branch
Collaborator
|
@MalavikaKrishnan100 : PR is outdated, please raise a new one as discussed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Telemetry Flag
Added telemtry for package identifier, Package creator and Artifactory uploader