Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1b1ad8d
maintainability issue fix
malavikakrishnan123 Feb 18, 2026
f5996ba
updated the file
malavikakrishnan123 Feb 18, 2026
e617c8c
Merge branch 'release/Hotfixv8.4.1' into feature/warningpipeline
MalavikaKrishnan100 Feb 18, 2026
25974c6
bomhelper and frameworkpackage maintainability issue fix
malavikakrishnan123 Feb 18, 2026
ac89d22
Merge branch 'feature/warningpipeline' of https://github.com/siemens/…
malavikakrishnan123 Feb 18, 2026
a868823
maintainability fix
malavikakrishnan123 Feb 18, 2026
38e1542
updated the maintainability fix
malavikakrishnan123 Feb 19, 2026
696768f
updated maintainability for pem signature verifier
malavikakrishnan123 Feb 19, 2026
224ce46
maintainability issue fix
malavikakrishnan123 Feb 19, 2026
59ad09e
updated the code
malavikakrishnan123 Feb 19, 2026
179a6db
the maintainability issue fix
malavikakrishnan123 Feb 19, 2026
459a47b
unit test updated
malavikakrishnan123 Feb 19, 2026
8c8f934
updated the test cases
malavikakrishnan123 Feb 19, 2026
37a6d50
updated the review
malavikakrishnan123 Feb 19, 2026
a34845f
test case update
malavikakrishnan123 Feb 19, 2026
0c2c1d0
reverted the change
malavikakrishnan123 Feb 19, 2026
9008b2c
added the unit test
malavikakrishnan123 Feb 19, 2026
b4d9b3d
fix the issue
malavikakrishnan123 Feb 19, 2026
4fe0736
removed the failing code
malavikakrishnan123 Feb 19, 2026
5ee0214
added the constant
malavikakrishnan123 Feb 20, 2026
721f4de
added the missed one
malavikakrishnan123 Feb 20, 2026
fb3b03d
Merge branch 'release/Hotfixv8.4.1' into feature/warningpipeline
crvreddy Feb 20, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 155 additions & 1 deletion src/AritfactoryUploader.UTest/PackageUploadHelperTest.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// --------------------------------------------------------------------------------------------------------------------
// --------------------------------------------------------------------------------------------------------------------
// SPDX-FileCopyrightText: 2025 Siemens AG
//
// SPDX-License-Identifier: MIT
Expand Down Expand Up @@ -573,6 +573,160 @@ public async Task JfrogFoundPackagesAsync_CargoComponentMultipleCalls_AddsMultip
Assert.AreEqual("tokio", displayPackagesInfo.JfrogFoundPackagesCargo[1].Name);
}

[Test]
public async Task JfrogNotFoundPackagesAsync_WithNullComponentType_DoesNotAddComponent()
{
// Arrange
var item = new ComponentsToArtifactory
{
ComponentType = null,
Name = "test-package",
Version = "1.0.0"
};
var displayPackagesInfo = new DisplayPackagesInfo
{
JfrogNotFoundPackagesNpm = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesNuget = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesMaven = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesPython = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesConan = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesDebian = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesCargo = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesChoco = new List<ComponentsToArtifactory>()
};

// Act
await PackageUploadHelper.JfrogNotFoundPackagesAsync(item, displayPackagesInfo);

// Assert - No components should be added to any list
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesNpm.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesNuget.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesMaven.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesPython.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesConan.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesDebian.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesCargo.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesChoco.Count);
}

[Test]
public async Task JfrogNotFoundPackagesAsync_WithEmptyComponentType_DoesNotAddComponent()
{
// Arrange
var item = new ComponentsToArtifactory
{
ComponentType = "",
Name = "test-package",
Version = "1.0.0"
};
var displayPackagesInfo = new DisplayPackagesInfo
{
JfrogNotFoundPackagesNpm = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesNuget = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesMaven = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesPython = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesConan = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesDebian = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesCargo = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesChoco = new List<ComponentsToArtifactory>()
};

// Act
await PackageUploadHelper.JfrogNotFoundPackagesAsync(item, displayPackagesInfo);

// Assert - No components should be added to any list
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesNpm.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesNuget.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesMaven.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesPython.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesConan.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesDebian.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesCargo.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesChoco.Count);
}

[Test]
public async Task JfrogNotFoundPackagesAsync_WithWhitespaceComponentType_DoesNotAddComponent()
{
// Arrange
var item = new ComponentsToArtifactory
{
ComponentType = " ",
Name = "test-package",
Version = "1.0.0"
};
var displayPackagesInfo = new DisplayPackagesInfo
{
JfrogNotFoundPackagesNpm = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesNuget = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesMaven = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesPython = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesConan = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesDebian = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesCargo = new List<ComponentsToArtifactory>(),
JfrogNotFoundPackagesChoco = new List<ComponentsToArtifactory>()
};

// Act
await PackageUploadHelper.JfrogNotFoundPackagesAsync(item, displayPackagesInfo);

// Assert - No components should be added to any list
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesNpm.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesNuget.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesMaven.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesPython.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesConan.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesDebian.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesCargo.Count);
Assert.AreEqual(0, displayPackagesInfo.JfrogNotFoundPackagesChoco.Count);
}

[Test]
public void WriteCreatorKpiDataToConsole_ValidUploaderKpiData_LogsDataSuccessfully()
{
// Arrange
var uploaderKpiData = new UploaderKpiData
{
ComponentInComparisonBOM = 100,
ComponentNotApproved = 10,
PackagesToBeUploaded = 90,
PackagesUploadedToJfrog = 85,
PackagesNotUploadedToJfrog = 5,
DevPackagesUploaded = 15,
DevPackagesNotUploadedToJfrog = 2,
InternalPackagesUploaded = 20,
InternalPackagesNotUploadedToJfrog = 3,
PackagesNotExistingInRemoteCache = 4,
PackagesNotUploadedDueToError = 1,
TimeTakenByArtifactoryUploader = 45.5
};

// Act & Assert - Should not throw any exceptions
Assert.DoesNotThrow(() => PackageUploadHelper.WriteCreatorKpiDataToConsole(uploaderKpiData));
}

[Test]
public void WriteCreatorKpiDataToConsole_WithZeroValues_LogsDataSuccessfully()
{
// Arrange
var uploaderKpiData = new UploaderKpiData
{
ComponentInComparisonBOM = 0,
ComponentNotApproved = 0,
PackagesToBeUploaded = 0,
PackagesUploadedToJfrog = 0,
PackagesNotUploadedToJfrog = 0,
DevPackagesUploaded = 0,
DevPackagesNotUploadedToJfrog = 0,
InternalPackagesUploaded = 0,
InternalPackagesNotUploadedToJfrog = 0,
PackagesNotExistingInRemoteCache = 0,
PackagesNotUploadedDueToError = 0,
TimeTakenByArtifactoryUploader = 0.0
};

// Act & Assert - Should not throw any exceptions
Assert.DoesNotThrow(() => PackageUploadHelper.WriteCreatorKpiDataToConsole(uploaderKpiData));
}
}
}
Loading