Merged
Conversation
Introduces a new `get` helper function to centralize HTTP requests to the snapshot client. This helper now validates the response's HTTP status code. A 404 error code will raise a `NotFoundOnSnapshotError`. All other client or server error codes will be caught by the `raise_for_status` function from the `requests` library and subsequently re-raised as a `SnapshotDataLakeError`. The only remaining status codes that the snapshot client is expected to return are 200 and 304, where the latter one cannot be returned, as an `If-Modified-Since` header is never specified. This implies that if no error is raised, the status code is 200 and the output is in the expected format. This prevents silent failures and subsequent issues like incorrect JSON parsing when the API returns unexpected content, ensuring earlier and clearer error detection. It also reduces the need for repetitive status code checks at each call site. Signed-off-by: Tamino Larisch <tamino.larisch@siemens.com>
Reapply checksum-related changes that were likely lost during a rebase. Signed-off-by: Tamino Larisch <tamino.larisch@siemens.com>
Replace the last occurrence of the manual package string formatting
`{srcpkg.name}@{srcpkg.version}` with its string representation.
Signed-off-by: Tamino Larisch <tamino.larisch@siemens.com>
Collaborator
|
Pretty sure I created the mess you fixed in 8769100, so thank you for fixing that ;) |
Urist-McGit
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new
gethelper function to centralize HTTP requests tothe snapshot client. This helper now validates the response's HTTP
status code. A 404 error code will raise a
NotFoundOnSnapshotError.All other client or server error codes will be caught by the
raise_for_statusfunction from therequestslibrary and subsequentlyre-raised as a
SnapshotDataLakeError. The only remaining status codesthat the snapshot client is expected to return are 200 and 304, where
the latter one cannot be returned, as an
If-Modified-Sinceheader isnever specified. This implies that if no error is raised, the status
code is 200 and the output is in the expected format.
This prevents silent failures and subsequent issues like incorrect JSON
parsing when the API returns unexpected content, ensuring earlier and
clearer error detection. It also reduces the need for repetitive status
code checks at each call site.