fix(apt-cache): also parse unsigned apt cache release files#173
Merged
Urist-McGit merged 3 commits intomainfrom Jan 21, 2026
Merged
fix(apt-cache): also parse unsigned apt cache release files#173Urist-McGit merged 3 commits intomainfrom
Urist-McGit merged 3 commits intomainfrom
Conversation
fmoessbauer
commented
Jan 21, 2026
fmoessbauer
force-pushed
the
fm/apt-unsigned-release
branch
from
c2e7c07 to
fb3f748
Compare
Member
Author
|
@Urist-McGit Please check why black fails in completely unrelated parts. |
Collaborator
The 26.1.0 black relase introduced a new rule |
Member
Author
Oh dear... That's why I hate mandatory code formatters. Doesn't black support turning on / off options? |
We anyways don't check the signature as we are not apt. But we need to parse the unsigned release files (ending in _Release) as well, as otherwise local apt sources are not processed. Fixes: 658b08a ("feat: add apt cache repository parsing") Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
In case we have ingress via --from-pkglist, we only have partial information about source packages. After loading the apt cache data, we have complete information, but potentially only for binary packages (in case we only have binary apt data). The binary apt data is sufficient to add the maintainer to the source package, which is highly important for the SBOM. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
fmoessbauer
force-pushed
the
fm/apt-unsigned-release
branch
from
f324289 to
4fb637b
Compare
Urist-McGit
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We anyways don't check the signature as we are not apt. But we need to parse the unsigned release files (ending in _Release) as well, as otherwise local apt sources are not processed.