feat(package): track if binary packages are essential#182
Open
fmoessbauer wants to merge 6 commits intomainfrom
Open
feat(package): track if binary packages are essential#182fmoessbauer wants to merge 6 commits intomainfrom
fmoessbauer wants to merge 6 commits intomainfrom
Conversation
Some tests currently assume that the dpkg-minimal status file only has a single package. To test for more corner cases, we want to add multiple packages to that file in the future, breaking the assumption that the file only has one. We now adjust the tests so that they do not assume that there is only a single package. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
This information is useful for information routing, as in debian essential packages are assumed to be always installed, hence do not need to be added to package dependencies. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
In CycloneDX we denote if a package is an essential package. Downstream tooling can use this information for improved dependency analysis. As SPDX does not offer a field for this information, this remains CDX only for now. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
This is a CycloneDX only feature, as SPDX does not encode this information. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Urist-McGit
reviewed
Mar 2, 2026
| entry.description = package.description | ||
| entry.properties.add(cdx_model.Property(name="section", value=package.section)) | ||
| entry.properties.add( | ||
| cdx_model.Property(name="essential", value="yes" if package.essential else "no") |
Collaborator
There was a problem hiding this comment.
Should we not use a simple True or False here? It should translate directly to the JSON boolean type
| add_key("purl", "string", "node") | ||
| add_key("type", "string", "node") | ||
| add_key("section", "string", "node") | ||
| add_key("essential", "string", "node") |
Collaborator
There was a problem hiding this comment.
If this property only exists for CDX SBOMs we want to document that. IIRC we recommend to use SPDX SBOMs for graph exporting since they contain better relationship information, so we might want to add this info there too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This information is useful for information routing, as in debian essential packages are assumed to be always installed, hence do not need to be added to package dependencies.