Open
Conversation
Author
|
debsbom filter command: |
fmoessbauer
reviewed
Mar 3, 2026
src/debsbom/commands/input.py
Outdated
| from ..util.sbom_processor import SbomProcessor | ||
| from ..resolver.resolver import PackageResolver, PackageStreamResolver | ||
| from ..sbom import SBOMType | ||
| from ..sbom import SBOMType, SPDX_REF_DOCUMENT |
Member
There was a problem hiding this comment.
Why do we import SPDX_REF_DOCUMENT here? This code location should be sbom type agnostic.
fmoessbauer
reviewed
Mar 3, 2026
| repack repack sources and sbom | ||
| export export SBOM as graph | ||
| delta list components added in target SBOM | ||
| filter filter SBOM by sources or binaries |
Member
There was a problem hiding this comment.
The commands are getting more and more. How about sorting them by alphabet?
Member
|
Hi @ssnaaz , thanks for implementing this. The implementation already looks pretty clean. Just some minor remarks that need to be fixed before merging. ... and please add a test (both a smoke test in the GH actions as well as a unit test). |
Signed-off-by: Syeda Shagufta Naaz <syedashagufta.naaz@siemens.com>
131e731 to
4e1e574
Compare
- filter the SBOM input by sources or binaries - preserve the dependency tree - sort commands alphabetically Signed-off-by: Syeda Shagufta Naaz <syedashagufta.naaz@siemens.com>
Signed-off-by: Syeda Shagufta Naaz <syedashagufta.naaz@siemens.com>
Author
|
@fmoessbauer Thank you for the feedback, I have updated the MR, please have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.