fix(dpkg): handle version type conversion#5
Merged
Urist-McGit merged 1 commit intosiemens:mainfrom Sep 8, 2025
Merged
Conversation
Collaborator
|
LGTM. I just noticed our CI did not run properly for PRs. Can you please rebase so the pipelines actually run? |
The SourcePackage and BinaryPackage version must be converted to a deb822 version type (even if it is provided as string) to later be able to access parts of the version (e.g. the epoch / source version / debian revision). We fix this by converting the version in the respective constructor. This avoid having to fix all the callers and also avoid exposing the dep822 type to all downstream users. When passing the version of a package to a downstream component, we further need to ensure we convert it to its string representation first. Fixes: 958c97d ("Initial commit") Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
fmoessbauer
force-pushed
the
fm/fix-package-version
branch
from
dc5d510 to
35f3584
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SourcePackage and BinaryPackage version must be converted to a deb822 version type (even if it is provided as string) to later be able to access parts of the version (e.g. the epoch / source version / debian revision).
We fix this by converting the version in the respective constructor. This avoid having to fix all the callers and also avoid exposing the dep822 type to all downstream users. When passing the version of a package to a downstream component, we further need to ensure we convert it to its string representation first.
Fixes: 958c97d ("Initial commit")