Fix/improve dependency handling#65
Merged
Urist-McGit merged 1 commit intosiemens:mainfrom Oct 13, 2025
Merged
Conversation
Member
|
Hi @tamilari, please rebase this PR against the latest main branch, as we don't do merge commits in this project. Once done, please just force-push. |
tamilari
force-pushed
the
fix/improveDependencyHandling
branch
2 times, most recently
from
34fc794 to
2a1ac77
Compare
Collaborator
|
CI is not working right now. Once #68 is merged, please rebase and I should be able to approve you. |
tamilari
force-pushed
the
fix/improveDependencyHandling
branch
2 times, most recently
from
2fb5990 to
6c8250c
Compare
fmoessbauer
reviewed
Oct 8, 2025
Member
fmoessbauer
left a comment
fmoessbauer
left a comment
There was a problem hiding this comment.
Regarding commit fix/improve missing dependency handling :
Please change the message to follow the conventional commits style.
fmoessbauer
reviewed
Oct 8, 2025
src/debsbom/cli.py
Outdated
| if args.cmd == "generate": | ||
| GenerateCmd.run(args) | ||
| elif not HAS_DOWNLOAD_DEPS: | ||
| print(f"{MISSING_MODULE}. {args.cmd} not available", file=sys.stderr) |
Member
There was a problem hiding this comment.
Please use the logger.error command for that to pass the message through the logging module.
Member
There was a problem hiding this comment.
An alternative is to just throw a runtime error here which is then catched in the error handler. By that, you can avoid the explicit sys.exit(-1).
tamilari
force-pushed
the
fix/improveDependencyHandling
branch
from
9f94730 to
64058f4
Compare
fmoessbauer
reviewed
Oct 8, 2025
fmoessbauer
reviewed
Oct 8, 2025
tamilari
force-pushed
the
fix/improveDependencyHandling
branch
from
1aa69e2 to
8f7fcf6
Compare
- Show the download, source-merge, and repack commands in the help message, even if the dependencies are not installed. This ensures consistency across all systems - Display a missing dependency error message when an unavailable command is used - Require one of the four commands to be specified so that calling debsbom alone will display a usage error message - Always import Compression from .util, regardless of whether the download dependencies are installed. This ensures that the parser is always set up with the correct compression options and results in consistent help messages Closes siemens#75: debsbom without subcommand shows empty output Signed-off-by: Tamino Larisch <tamino.larisch@siemens.com>
tamilari
force-pushed
the
fix/improveDependencyHandling
branch
from
8f7fcf6 to
c22e498
Compare
Collaborator
|
LGTM, what do you think @fmoessbauer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message, even if the dependencies are not installed. This ensures
consistency across all systems
is used
debsbom alone will display a usage error message
download dependencies are installed. This ensures that the parser is
always set up with the correct compression options and results in
consistent help messages