refactor(navbar): remove deprecated navbar component#1179
Draft
akashsonune wants to merge 1 commit into
Draft
Conversation
akashsonune
commented
Dec 10, 2025
akashsonune
commented
Member
- I confirm that this MR follows the contribution guidelines.
akashsonune
force-pushed
the
refactor/remove-deprecated-navbar-component
branch
8 times, most recently
from
1c145c2 to
9397ff5
Compare
|
Documentation. Coverage Reports: |
akashsonune
force-pushed
the
refactor/remove-deprecated-navbar-component
branch
2 times, most recently
from
6c39f19 to
1e09422
Compare
|
|
akashsonune
added
the
breaking-changes
Member
Author
|
@spike-rabbit do we want to delay this one or merge for 49? |
Member
Author
@spike-rabbit WDYT? |
Member
|
yes, we should at least wait until then |
Member
Author
|
ok lets park it for v50 for now |
akashsonune
force-pushed
the
refactor/remove-deprecated-navbar-component
branch
from
1e09422 to
6491c54
Compare
BREAKING CHANGE: Removed the deprecated `SiNavbarModule`. Use the new `si-application-header` instead.
akashsonune
force-pushed
the
refactor/remove-deprecated-navbar-component
branch
from
6491c54 to
b2bd44a
Compare
Member
Author
|
@spike-rabbit Shall we remove this component for v51? |
Member
|
moved to v52 as we still need to discuss if there will be a factory alternative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.