refactor(theme): use only a min-block-size for .dropdown-item#1935
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors badge and dropdown styles by centralizing badge-related variables and updating dropdown dimensions for better consistency. Key changes include replacing hardcoded values in _badges.scss with variables, removing an explicit block-size in _dropdowns.scss, and adjusting dropdown line-height and padding. Feedback was provided to remove a redundant comment in the variables file.
dr-itz
force-pushed
the
refactor/theme/menu-item-no-block-size
branch
from
40902ea to
a66664d
Compare
dr-itz
changed the title
dr-itz
force-pushed
the
refactor/theme/menu-item-no-block-size
branch
from
a66664d to
101d8a1
Compare
dr-itz
force-pushed
the
refactor/theme/menu-item-no-block-size
branch
2 times, most recently
from
1ade1d4 to
9409df8
Compare
The largest item in a menu item is the badge, so extend line-height to that and adjust padding instead. There's no longer a requirement for a fixed height, rather a min height so that items w/o text content get the proper height
dr-itz
force-pushed
the
refactor/theme/menu-item-no-block-size
branch
from
9409df8 to
92550ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The largest item in a menu item is the badge, so extend line-height to
that and adjust padding instead. There's no longer a requirement for
a fixed height, rather a min height so that items w/o text content get
the proper height
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: