fix(ux): update texts from ux writing review#1947
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates localized strings across a wide range of components to better align with the Siemens UX writing guidelines, emphasizing conciseness and consistent terminology. Feedback was provided to address remaining style guide violations, specifically regarding the use of full sentences on interactive pages, improper capitalization in button labels, and the use of abbreviations with periods. Suggestions were also made to remove superfluous words to ensure the UI text remains as brief and clear as possible.
michael-smt
added
the
ux
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
@michael-smt this PR has some conflicts and failing pipelines
michael-smt
force-pushed
the
feat/ux-writing-review
branch
from
0975451 to
df6d741
Compare
michael-smt
changed the title
michael-smt
force-pushed
the
feat/ux-writing-review
branch
3 times, most recently
from
6c121c3 to
e7439af
Compare
michael-smt
force-pushed
the
feat/ux-writing-review
branch
2 times, most recently
from
54c9aab to
a589d7f
Compare
|
Rebased, fixed tests and updated all snapshots from the VRT update pipeline job. To keep the amount of changes low only reviewed (approved) strings from UX writing are updated. |
michael-smt
force-pushed
the
feat/ux-writing-review
branch
3 times, most recently
from
b4b9f71 to
87c5e44
Compare
michael-smt
dismissed
spike-rabbit’s stale review
Rebased, fixed tests and updated all snapshots from the VRT update pipeline job.
|
|
||
| await expect(page.getByText('Application Name')).toBeVisible(); | ||
| const toggler = page.getByLabel('Toggle navigation'); | ||
| const toggler = page.getByLabel('Show navigation'); |
There was a problem hiding this comment.
@michael-smt @spike-rabbit Toggle and show have different meaning - then we would need to change it to hide navigation afterwards, no?
There was a problem hiding this comment.
A "toggle" is basically a checkbox with a active and inactive state, right? So for a11y one could argue Show navigation is correct as a label for something that semantically resembles this:
Show navigation
There was a problem hiding this comment.
yes exactly, the screen reader announces in this case either:
Show navigation expanded / Show navigation collapsed
There was a problem hiding this comment.
ah ok, yeah then this is fair.
@spike-rabbit Do you want to review all the texts here or who should do what to get this in asap?
michael-smt
force-pushed
the
feat/ux-writing-review
branch
from
87c5e44 to
dda343d
Compare
michael-smt
force-pushed
the
feat/ux-writing-review
branch
from
dda343d to
04304c0
Compare
4 participants
Backports the reviewed strings from UX writing English into the default texts.
Updates to docs images, Figma etc. will follow after a initial review of the texts.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: