feat(form): support Angular's signal forms with new si-form-field#2272
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new SiFormFieldComponent and its configuration provider to support Angular signal forms, along with an example form and corresponding E2E tests. The feedback focuses on adhering to the repository style guide by replacing state-propagating effect() calls with computed() signals in the form field component, and aligning user-facing error messages and checkbox labels with the Siemens UX writing guidelines (e.g., using telegram style, avoiding abbreviations, and removing trailing punctuation). E2E test assertions should also be updated to match these revised text labels.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
spike-rabbit
force-pushed
the
feat/forms/form-field-component
branch
from
fcacf86 to
860c76e
Compare
spike-rabbit
force-pushed
the
feat/forms/form-field-component
branch
from
860c76e to
2c2dff2
Compare
spike-rabbit
force-pushed
the
feat/forms/form-field-component
branch
from
2c2dff2 to
1b8950d
Compare
spike-rabbit
force-pushed
the
feat/forms/form-field-component
branch
2 times, most recently
from
f1312ba to
124e630
Compare
Introduces a new component called `si-form-field` which is built around Angular's signal forms. This initial version only supports native browser inputs. Currently missing: - integration of the error resolution mechanism - label in a separate column - fieldset combination with fieldset - documentation
spike-rabbit
force-pushed
the
feat/forms/form-field-component
branch
from
124e630 to
5f0f052
Compare
4 participants
Introduces a new component called
si-form-fieldwhich is built around Angular's signal forms.This initial version only supports native browser inputs. Currently missing:
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: