feat(split): migrate si-split to OnPush#2281
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the split component and its parts to migrate from traditional decorators to Angular's modern signal-based APIs, including input(), contentChildren(), and linkedSignal(), alongside updating templates and unit tests to use signal getters and modern async test stabilization. The review feedback highlights two critical improvements: refactoring imperative effect() blocks in SiSplitPartComponent to declarative computed and linkedSignal properties to align with the repository style guide, and declaring grid template signals as read-only computed class properties in SiSplitComponent instead of dynamically reassigning them.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
e74dd94 to
a6e6b05
Compare
BREAKING CHANGE: si-split and si-split-part inputs were migrated to signal inputs
a6e6b05 to
14c581e
Compare
BREAKING CHANGE: si-split and si-split-part inputs were migrated to signal inputs
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: