Skip to content

feat(split): migrate si-split to OnPush#2281

Open
spliffone wants to merge 1 commit into
mainfrom
feat/spli-onpush
Open

feat(split): migrate si-split to OnPush#2281
spliffone wants to merge 1 commit into
mainfrom
feat/spli-onpush

Conversation

@spliffone

@spliffone spliffone commented Jul 6, 2026

Copy link
Copy Markdown
Member

BREAKING CHANGE: si-split and si-split-part inputs were migrated to signal inputs


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@spliffone spliffone requested review from a team as code owners July 6, 2026 08:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the split component and its parts to migrate from traditional decorators to Angular's modern signal-based APIs, including input(), contentChildren(), and linkedSignal(), alongside updating templates and unit tests to use signal getters and modern async test stabilization. The review feedback highlights two critical improvements: refactoring imperative effect() blocks in SiSplitPartComponent to declarative computed and linkedSignal properties to align with the repository style guide, and declaring grid template signals as read-only computed class properties in SiSplitComponent instead of dynamically reassigning them.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/element-ng/split/si-split-part.component.ts Outdated
Comment thread projects/element-ng/split/si-split.component.ts Outdated
@spliffone spliffone added the breaking-changes Marks issues and PRs that are breaking the API label Jul 6, 2026
@spliffone spliffone added this to the 51.x milestone Jul 6, 2026
@spliffone spliffone force-pushed the feat/spli-onpush branch 3 times, most recently from e74dd94 to a6e6b05 Compare July 7, 2026 19:49
BREAKING CHANGE: si-split and si-split-part inputs were migrated to signal inputs
@spliffone spliffone modified the milestones: 51.x, 51.0.0 Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-changes Marks issues and PRs that are breaking the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant