Skip to content

docs(localization): improve translation key override example#2294

Merged
spike-rabbit merged 2 commits into
mainfrom
docs/localization-key-override
Jul 8, 2026
Merged

docs(localization): improve translation key override example#2294
spike-rabbit merged 2 commits into
mainfrom
docs/localization-key-override

Conversation

@michael-smt

@michael-smt michael-smt commented Jul 8, 2026

Copy link
Copy Markdown
Member

A different import path is needed and the example key name is invalid.


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the localization documentation to use the correct import path from @siemens/element-ng/translate and changes the translation keys to use underscores instead of hyphens. Feedback was provided to update the example code to use ApplicationConfig instead of @NgModule to align with the project's style guide preference for standalone components.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docs/fundamentals/localization.md
@michael-smt michael-smt marked this pull request as ready for review July 8, 2026 13:16
@michael-smt michael-smt requested review from a team as code owners July 8, 2026 13:16

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit spike-rabbit added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 1b9c797 Jul 8, 2026
15 checks passed
@spike-rabbit spike-rabbit deleted the docs/localization-key-override branch July 8, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants