feat(live-previewer): limit number of log messages - #2664
Open
spliffone wants to merge 1 commit into
Open
Conversation
spliffone
force-pushed
the
feat/live-previewer-performance
branch
from
August 31, 2026 20:13
029436d to
7cdb051
Compare
Member
|
not sure we need this: logEvent() is meant as a way to demo event handling. If your playing with stuff or debugging, the good old console.log() is the way to go 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the live-previewer to limit the logs.
Problem
While playing with maplibre to analyze a rendering issue I used the
logEventand to see what is happening during during resize and other map events. Logging does events slowed down the browser within seconds since the amount of data raised to multiple MB.Proposal
We create a ring buffer to limit the amount of data and also limit the size of the log message so we don't run into this issue anymore.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: