Skip to content

docs(event-list): fix property names#2133

Merged
nuke-ellington merged 5 commits into
mainfrom
fix/3237-event-list-color
Oct 2, 2025
Merged

docs(event-list): fix property names#2133
nuke-ellington merged 5 commits into
mainfrom
fix/3237-event-list-color

Conversation

@nuke-ellington

Copy link
Copy Markdown
Collaborator

💡 What is the current behavior?

Item color will not be shown in examples

GitHub Issue Number: IX-3237

🆕 What is the new behavior?

  • Changed property names from color to itemColor to fix issue
  • Added ix-event-list stories

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@changeset-bot

changeset-bot Bot commented Sep 12, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 725fec2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nuke-ellington

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the color property to itemColor across numerous files, ensuring consistency and fixing the described issue. The addition of Storybook stories for the ix-event-list component is a valuable enhancement for documentation and testing. I've provided a couple of suggestions on the new story file to improve type safety and performance.

Comment thread packages/storybook-docs/src/stories/event-list.stories.ts Outdated
Comment thread packages/storybook-docs/src/stories/event-list.stories.ts Outdated
lzeiml
lzeiml previously approved these changes Sep 26, 2025
@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2025

Copy link
Copy Markdown

@nuke-ellington nuke-ellington merged commit 6aee304 into main Oct 2, 2025
14 checks passed
@nuke-ellington nuke-ellington deleted the fix/3237-event-list-color branch October 2, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants