feat(core): elevation changes #2155
Conversation
🦋 Changeset detectedLatest commit: 9911cdd The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @danielleroux, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the visual flexibility and consistency of several components by introducing a new 'variant' property and applying extensive theme adaptations. The changes streamline styling definitions, making it easier to customize component appearances and ensuring a more cohesive design system. It also includes a breaking change for the ix-flip-tile component, where its 'state' property has been renamed to 'variant' for better alignment with the new system.
Highlights
- New Component Variants: Introduced a new 'variant' property for
ix-card-accordion,ix-event-list-item, andix-flip-tilecomponents, allowing for diverse visual styles such as 'outline' and 'filled'. - Breaking Change: Flip Tile Property Rename: The
ix-flip-tilecomponent's 'state' property has been renamed to 'variant' to align with the new variant system. Corresponding type definitions (FlipTileStatetoFlipTileVariant) have also been updated. - Comprehensive Theme Adaptations: Applied new elevation styles and refactored numerous component-specific SCSS variables across the classic dark and light themes, centralizing styling definitions and improving consistency.
- New Component Theming: Added dedicated SCSS theming files for
ix-action-card,ix-card,ix-pagination,ix-pane,ix-progress-indicator, andix-push-card, providing granular control over their appearance. - Documentation and Storybook Enhancements: Updated component documentation and Storybook examples to reflect the new variant properties and styling options, including new stories for
ix-event-list-item,ix-event-list,ix-pane,ix-slider, andix-tile.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces significant elevation and variant changes across multiple components, which is a great step towards a more consistent and themeable design system. The refactoring of SCSS files to use loops and variables for variants is a major improvement for maintainability. I've also noticed a pattern of reordering CSS variables in many component SCSS files. While this is a stylistic choice, I've added some suggestions to group related variables (e.g., base, hover, active states) together for better readability. Overall, this is a solid set of changes.
|
/release:pr |
|
A new release has been made for this PR. You can install it with: Core library: Angular: React: Vue: |
nuke-ellington
left a comment
nuke-ellington
left a comment
There was a problem hiding this comment.
Theme generator should already be updated with the mentioned changes
|
/release:pr |
|
A new release has been made for this PR. You can install it with: Core library: Angular: React: Vue: |
|
2 participants
🆕 What is the new behavior?
Jira IX-3075 IX-3154
Docs changes: siemens/ix-docs#85
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support