Skip to content

Add advanced ix-application example to test apps#2167

Merged
danielleroux merged 13 commits into
mainfrom
ix-application-example
Oct 6, 2025
Merged

Add advanced ix-application example to test apps#2167
danielleroux merged 13 commits into
mainfrom
ix-application-example

Conversation

@AndreasBerliner

@AndreasBerliner AndreasBerliner commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

💡 What is the current behavior?

There is no comprehensive and interactive example for the ix-application.

🆕 What is the new behavior?

  • A comprehensive and interactive example for the ix-application was added to the test apps.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

@changeset-bot

changeset-bot Bot commented Sep 24, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0c62762

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AndreasBerliner AndreasBerliner marked this pull request as ready for review September 24, 2025 08:57
@lzeiml lzeiml self-requested a review September 25, 2025 07:55
@lzeiml

lzeiml commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new advanced example for the ix-application component across Angular (standalone and module-based), React, Vue, and pure HTML/JS test apps. The changes are well-structured and provide a good interactive demonstration. My review includes suggestions to improve maintainability and performance by reducing code duplication and simplifying the rendering logic in the templates for Angular, React, and Vue. I've also suggested a refactoring for the vanilla JavaScript implementation to make it more efficient and robust.

Comment thread packages/angular-test-app/src/preview-examples/application-advanced.html Outdated
Comment thread packages/vue-test-app/src/preview-examples/application-advanced.vue
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
6 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@danielleroux danielleroux merged commit 4b574b3 into main Oct 6, 2025
11 checks passed
@danielleroux danielleroux deleted the ix-application-example branch October 6, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants