-
Notifications
You must be signed in to change notification settings - Fork 135
feat(echarts): extend peer dependency support for ECharts 6 #2580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8332cea
updated ix/echarts version to 6
varun-srinivasa c65ed17
added changeset and addressed gemini review comment
varun-srinivasa d867b4a
Merge branch 'main' into fix/ix-4318
khathija-ahamadi 038dca7
updated package.json to use echarts v5
varun-srinivasa 9a99e94
updated pnpm lock file
varun-srinivasa 32d8e2b
updated VRT's for V5 and V6 echarts
varun-srinivasa a3285b5
added doctype to basic echarts
varun-srinivasa bb0962f
Merge branch 'main' into fix/ix-4318
danielleroux 565dbc1
docs(echarts): bring examples closer to figma
nuke-ellington 5627133
updated basic html pages to have a title
varun-srinivasa 90d0c36
updated changeset
varun-srinivasa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@siemens/ix-echarts': major | ||
| --- | ||
|
|
||
| Updated dependencies of `echarts` to support `^6.0.0` |
|
danielleroux marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
danielleroux marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-571 Bytes
(98%)
.../echarts.e2e.ts-snapshots/echarts-basic-1-chromium---theme-brand-dark-linux.png
|
nuke-ellington marked this conversation as resolved.
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1000 Bytes
(97%)
...echarts.e2e.ts-snapshots/echarts-basic-1-chromium---theme-brand-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-400 Bytes
(99%)
...charts.e2e.ts-snapshots/echarts-basic-1-chromium---theme-classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-803 Bytes
(98%)
...harts.e2e.ts-snapshots/echarts-basic-1-chromium---theme-classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-583 Bytes
(98%)
...ts.e2e.ts-snapshots/echarts-more-colors-1-chromium---theme-brand-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.03 KB
(97%)
...s.e2e.ts-snapshots/echarts-more-colors-1-chromium---theme-brand-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-446 Bytes
(99%)
....e2e.ts-snapshots/echarts-more-colors-1-chromium---theme-classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-928 Bytes
(97%)
...e2e.ts-snapshots/echarts-more-colors-1-chromium---theme-classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
|
danielleroux marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.