-
Notifications
You must be signed in to change notification settings - Fork 135
feat(core/time-input): time input validation improvements #2629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RamVinayMandal
wants to merge
14
commits into
siemens:main
Choose a base branch
from
RamVinayMandal:fix-ix-3322-time-input-validation-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bab3d39
feat(time-input): enhance validation and accessibility features
RamVinayMandal ef0116f
fix(time-input): improve validation handling and accessibility features
RamVinayMandal caacf3f
Implement code changes to enhance functionality and improve performance
RamVinayMandal dae9b77
feat: test cases finalized. removed unnecessary method call from timeโฆ
RamVinayMandal 7999216
Merge branch 'main' into fix-ix-3322-time-input-validation-improvements
RamVinayMandal 54e06bf
addressed gemini review comments and added fix for novalidate form blโฆ
RamVinayMandal 522b5c2
Merge branch 'fix-ix-3322-time-input-validation-improvements' of githโฆ
RamVinayMandal b42b428
chore: update version annotations for time input validation methods tโฆ
RamVinayMandal 145cdb5
fix: improve time input validation messages and cleanup code
RamVinayMandal 522c06c
Merge branch 'main' into fix-ix-3322-time-input-validation-improvements
RamVinayMandal f3946eb
refactor: rename syncValidityToFormInternals to syncFormInternalsValiโฆ
RamVinayMandal 9858e7a
Merge branch 'fix-ix-3322-time-input-validation-improvements' of githโฆ
RamVinayMandal 89dace5
Merge branch 'main' into fix-ix-3322-time-input-validation-improvements
RamVinayMandal 1bcf90b
refactor(time-input): remove unused focusInputIfKeyboardMode functionโฆ
RamVinayMandal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| '@siemens/ix': minor | ||
| --- | ||
|
|
||
| Added `clear()` method to reset value and validation state, removing all visual error indicators even after the field has been touched. | ||
|
|
||
| Added `reportValidity()` method to programmatically trigger validation and show visual error state immediately. | ||
|
|
||
| Added `i18nErrorRequired` prop (`i18n-error-required`) to customize the required-field error message. | ||
|
|
||
| Fixed validation behavior for `ix-time-input`: | ||
|
|
||
| - Non-required field is now valid when the value is removed (keyboard deletion or programmatic empty string). | ||
| - Required field shows required-missing error only when empty and touched, or after `reportValidity()`. | ||
| - Visual validation errors only appear after first blur; programmatic value changes are validated internally without visual feedback until interaction. | ||
| - `novalidate` forms suppress all visual validation while `reportValidity()` overrides this suppression. | ||
| - Dynamically toggling the `required` attribute immediately reflects correct validation state. | ||
| - Clicking and holding time values does not trigger validation errors on required empty fields; removed momentary red-border flash when selecting a time. | ||
| - Form submission is now prevented when the field is invalid or required but empty; submission proceeds only when the field is valid (form-associated component with ElementInternals validation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.