Skip to content

fix(storybook-docs): update modal accessibility examples#2636

Open
SaiYugandhar03 wants to merge 5 commits into
siemens:mainfrom
SaiYugandhar03:fix/ix-modal-storybook-update
Open

fix(storybook-docs): update modal accessibility examples#2636
SaiYugandhar03 wants to merge 5 commits into
siemens:mainfrom
SaiYugandhar03:fix/ix-modal-storybook-update

Conversation

@SaiYugandhar03

@SaiYugandhar03 SaiYugandhar03 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

💡 What is the current behavior?

Interactive buttons are not placed in both examples. The Default (Blocking) example does not block focus on the content buttons as expected, and although the non-blocking example works correctly, its content alignment is not proper.

Jira-ticket: IX-4256

🆕 What is the new behavior?

Interactive buttons are placed in both examples. The Default (Blocking) example correctly prevents focus on the content buttons, and the non-blocking example works correctly with the content properly aligned.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Summary by CodeRabbit

  • Bug Fixes
    • Improved modal accessibility examples so the blocking version uses a proper backdrop.
    • Updated modal demos to show interactive content both behind and inside the dialog, making behavior clearer in Storybook.

@netlify

netlify Bot commented Jul 2, 2026

Copy link
Copy Markdown

Deploy Preview for ix-storybook ready!

Name Link
🔨 Latest commit 7385f55
🔍 Latest deploy log https://app.netlify.com/projects/ix-storybook/deploys/6a4cc5d4222a5f00086ff0e6
😎 Deploy Preview https://deploy-preview-2636--ix-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot

changeset-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7385f55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-docs Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 644a68c5-5a25-4b1a-9c5e-260d421fe121

📥 Commits

Reviewing files that changed from the base of the PR and between e46872b and 7385f55.

📒 Files selected for processing (2)
  • .changeset/bright-jars-breathe.md
  • packages/storybook-docs/src/stories/modal/accessibility/a11y-modal.stories.ts

📝 Walkthrough

Walkthrough

Adds an openModal async play helper to Storybook modal accessibility stories that waits for ix-modal definition and calls showModal(), wires it into the Default and NonBlocking stories, inserts background <ix-button> elements, and adds a corresponding changeset entry.

Changes

Modal accessibility demo updates

Layer / File(s) Summary
openModal helper and Default story wiring
packages/storybook-docs/src/stories/modal/accessibility/a11y-modal.stories.ts
Adds an async openModal helper that waits for ix-modal to be defined and calls showModal(), adds two background <ix-button> elements to the Default story render, and wires play: openModal on Default.
NonBlocking story wiring
packages/storybook-docs/src/stories/modal/accessibility/a11y-modal.stories.ts
Adds two background <ix-button> elements to the NonBlocking story render and wires play: openModal on NonBlocking.
Changeset entry
.changeset/bright-jars-breathe.md
Documents a patch release for @siemens/ix describing the updated modal accessibility examples.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: nuke-ellington

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main change: updating Storybook modal accessibility examples in storybook-docs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the modal accessibility Storybook examples by adding background buttons to both the blocking and non-blocking stories, and introducing an openModal play function to automatically trigger the modal. The review feedback recommends waiting for componentOnReady() before calling showModal() on the Stencil component to prevent potential race conditions during loading.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2026

Copy link
Copy Markdown

@SaiYugandhar03 SaiYugandhar03 marked this pull request as ready for review July 7, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant