fix(storybook-docs): update modal accessibility examples#2636
fix(storybook-docs): update modal accessibility examples#2636SaiYugandhar03 wants to merge 5 commits into
Conversation
✅ Deploy Preview for ix-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 7385f55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds an ChangesModal accessibility demo updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the modal accessibility Storybook examples by adding background buttons to both the blocking and non-blocking stories, and introducing an openModal play function to automatically trigger the modal. The review feedback recommends waiting for componentOnReady() before calling showModal() on the Stencil component to prevent potential race conditions during loading.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|



💡 What is the current behavior?
Interactive buttons are not placed in both examples. The Default (Blocking) example does not block focus on the content buttons as expected, and although the non-blocking example works correctly, its content alignment is not proper.
Jira-ticket: IX-4256
🆕 What is the new behavior?
Interactive buttons are placed in both examples. The Default (Blocking) example correctly prevents focus on the content buttons, and the non-blocking example works correctly with the content properly aligned.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support
Summary by CodeRabbit