Skip to content

Add SSH support for rootless docker #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Conversation

aidanmoss
Copy link

@aidanmoss aidanmoss commented Apr 17, 2025

Currently attempting to use the "--ssh-dir" option will import a directory into a docker container that is still owned by the root user of the container.

This does not work as "builder" cannot access these files making this option useless in a rootless environment. This PR adds a small change to check for the existence of the ssh directory if it exist and changes its ownership to the appropriate user.

@jan-kiszka
Copy link
Collaborator

Thanks for the report and the fix proposal. Could you send it to our mailing list (see https://github.com/siemens/kas/blob/master/CONTRIBUTING.md)?

I'm now wondering if this is really the only remaining case. Did you check that as well?

@aidanmoss
Copy link
Author

Something odd is happening with my 'git send-email` this morning, but just sent the patch to the mailing list.

I know the ssh-agent runs into a similar issue as well but I don't have a solution for it at the moment, I'll look into the other options as well and see if other ones also have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants