Skip to content

fix(kas-container): preserve quoting in --runtime-args values #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linzhp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(kas-container): preserve quoting in --runtime-args values #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions kas-container
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,8 +782,14 @@ fi

# SC2086: Double quote to prevent globbing and word splitting.
# shellcheck disable=2086
set -- "$@" ${KAS_ISAR_ARGS} ${KAS_RUNTIME_ARGS} ${KAS_EXTRA_RUNTIME_ARGS} \
${KAS_CONTAINER_IMAGE} ${KAS_OPTIONS_DIRECT} ${KAS_CMD} ${KAS_OPTIONS}
set -- "$@" ${KAS_ISAR_ARGS} ${KAS_RUNTIME_ARGS}
# eval so that quoting inside --runtime-args values is honored, allowing
# runtime arguments whose values contain spaces, e.g.
# --runtime-args "--device-cgroup-rule 'b 7:* rmw'"
eval "set -- \"\$@\" ${KAS_EXTRA_RUNTIME_ARGS}"
# SC2086: Double quote to prevent globbing and word splitting.
# shellcheck disable=2086
set -- "$@" ${KAS_CONTAINER_IMAGE} ${KAS_OPTIONS_DIRECT} ${KAS_CMD} ${KAS_OPTIONS}
if [ -n "${KAS_BITBAKE_C_OPTION_ARGS}" ]; then
set -- "$@" -c "${KAS_BITBAKE_C_OPTION_ARGS}"
fi
Expand Down