PYR1-1556 Fix call-sql bigint arg overflow - #154
Merged
Conversation
lambdatronic
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
call-sqlnarrowed every integer argument to a 32-bit int before binding it, so a valuepast about 2.1 billion (an epoch-millisecond timestamp, for example) threw an integer-overflow
error before it ever reached Postgres, even when the target column was a bigint.
It now narrows an integer only when it fits in 32 bits and leaves larger values as 64-bit longs,
which bind to bigint parameters correctly. In-range values are untouched, so existing callers
behave exactly as before. The same guard covers the double-to-float narrowing, which had the
matching overflow on very large doubles.
Adds unit tests for the coercion and for the
call-sqlwiring.