PYR1-1520 PYR1-1521 Opt-in Secure session cookies and HSTS - #156
Merged
Conversation
lambdatronic
self-requested a review
July 1, 2026 11:27
lambdatronic
requested changes
Jul 1, 2026
lambdatronic
left a comment
lambdatronic
left a comment
Member
There was a problem hiding this comment.
Please remember to add the new keys to src/triangulum/config_namespaced_spec.clj.
lambdatronic
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This adds two opt-in config keys for HTTPS hardening, both off by default, so existing deployments don't change. Set
:triangulum.handler/session-cookie-attrsto a map merged onto the session cookie, like{:secure true :same-site :lax}, or leave it unset to keep ring's defaults. Set:triangulum.handler/hsts? trueto send an HSTS header when served over HTTPS.Only deployments that set these keys get the hardening, so it's backward-compatible. Tests cover both the default and opt-in paths.