Skip to content

improve the file of docs #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amit-friday wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve the file of docs #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions doc/spec/def.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,17 @@ message HydratedURLButton {
optional string url = 2;
}

message HydratedCallButton {
message HydratedCallButton
{
optional string displayText = 1;
optional string phoneNumber = 2;
}

message HydratedTemplateButton {
message HydratedTemplateButton
{
optional uint32 index = 4;
oneof hydratedButton {
oneof hydratedButton
{
HydratedQuickReplyButton quickReplyButton = 1;
HydratedURLButton urlButton = 2;
HydratedCallButton callButton = 3;
Expand Down Expand Up @@ -100,6 +103,8 @@ message ContextInfo {

message SenderKeyDistributionMessage {
optional string groupId = 1;
optional string participant = 2;
Copy link
Copy Markdown
Collaborator

@quad quad May 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ participant and axolotlSenderKeyDistributionMessage share the same tag ID (2)

Which should take priority?

optional bytes conversionData = 19;
optional bytes axolotlSenderKeyDistributionMessage = 2;
}

Expand Down