get statuses in client#357
Open
hossinasaadi wants to merge 7 commits into
Open
Conversation
Contributor
hossinasaadi
commented
Feb 11, 2022
hossinasaadi
commented
- add statuses response to client
- add sorted contacts
- update Whatsapp Web version to 2,2136,10
Contributor
Author
Contributor
Author
|
I’m working on listing statuses in client on new branch, so need this to merge @quad :D Screen.Recording.2022-02-12.at.6.41.1.mov |
Contributor
|
Why do you use camel case? In Python, the convention is snake case. |
Contributor
Author
|
Hi @OmerFI , actually I’m following project structure :) |
quad
approved these changes
Mar 4, 2022
Comment on lines
+186
to
+198
| try: | ||
| if processedData[1]['type'] is "contacts": | ||
| messageType = "jsonContacts"; | ||
| processedData.append(self.sortedContacts(processedData)) | ||
| except: | ||
| pass | ||
| # sort statuses | ||
| try: | ||
| if processedData[2][0][0] is "status": | ||
| processedData[2] = self.sortedStatuses(processedData) | ||
| messageType = "jsonStatuses"; | ||
| except: | ||
| pass |
Collaborator
There was a problem hiding this comment.
Are these exceptions caught as a result of, say, processedData[1]['type'] throwing IndexError or something?
Contributor
Author
There was a problem hiding this comment.
yes, some responses don’t have a 'type' key, like 'action' response.
so sometimes it throws an error but try/except will handle that.
Contributor
Author
There was a problem hiding this comment.
Are these exceptions caught as a result of, say,
processedData[1]['type']throwing IndexError or something?
@quad any problem ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.