feat(fiat-shamir): absorb morphism structure into transcript codec #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 3, 2025 15:11
This commit introduces a new `HasGroupMorphism` trait to allow SigmaProtocol implementations to expose their underlying group morphism structure. A helper method `absorb_morphism_structure` was added to the trait, enabling a standard way to serialize and absorb the morphism constraints into a transcript codec during Fiat-Shamir initialization. Changes include: - Definition of `HasGroupMorphism` with `group_morphism()` accessor - Default implementation of `absorb_morphism_structure` using term indices - Conditional `impl` block in `NISigmaProtocol` for protocols implementing `HasGroupMorphism`, enabling morphism-to-transcript absorption - Unit test in `tests/morphism_preimage.rs` to verify correctness This prepares the ground for composable Fiat-Shamir transformations that include problem structure in the transcript, improving soundness under rewinding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new
HasGroupMorphismtrait to allow SigmaProtocol implementations to expose their underlying group morphism structure.A helper method
absorb_morphism_structurewas added to the trait, enabling a standard way to serialize and absorb the morphism constraints into a transcript codec during Fiat-Shamir initialization.Changes include:
HasGroupMorphismwithgroup_morphism()accessorabsorb_morphism_structureusing term indicesimplblock inNISigmaProtocolfor protocols implementingHasGroupMorphism, enabling morphism-to-transcript absorptiontests/morphism_preimage.rsto verify correctnessThis prepares the ground for composable Fiat-Shamir transformations that include problem structure in the transcript, improving soundness under rewinding.
#14