Add robustness tests for proof tampering and malformed encodings #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chausseaumoine
changed the title
Collaborator
|
@Chausseaumoine can you please update the PR with an auxiliary function and use type generics instead of duplicated code? |
added 5 commits
July 20, 2025 17:03
…script: - flipping bytes - extra bytes (heading, middle of proof, trailing) - creating proof with wrong witness
mmaker
added a commit
that referenced
this pull request
Jul 21, 2025
This is part of #58. Co-Authored-By: =?UTF-8?q?GOURIOU=20L=C3=A9na=C3=AFck?= <[email protected]>
mmaker
force-pushed
the
main
branch
2 times, most recently
from
faebdc6 to
a8e5a27
Compare
mmaker
added a commit
that referenced
this pull request
Jul 25, 2025
This file is meant to check for edge cases in the instance as considered "valid" and in the proof as to be parsed and verified correctly. Related to PR #58. Co-Authored-By: GOURIOU <[email protected]>
Collaborator
|
@Chausseaumoine: I created a test file that is just focused on validation criterias for the zkproof. Can you please double-check I'm not forgetting anything? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a set of robustness tests to ensure the verifier rejects tampered or invalid proofs.
It covers:
Apply these to DLog, Pedersen with both BLS and Ristretto proofs.