Optimize small MSMs by using a naive implementation under size 16 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaker
approved these changes
Sep 22, 2025
Collaborator
|
Idk how you got the idea of testing it against the naive impl, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into the performance of the OONI application, I realized that a naive MSM was producing better performance. It turns out that the naive MSM is better for small sizes, compared to the provided implementation of Pippenger's algorithm. This PR updates the MSM implementation to use a naive formula for inputs of size less than 16. 16 is chosen somewhat arbitrarily, by looking at the cross-over point in the (new) benchmark on my laptop.