Skip to content

Opt-in caching to speed up search of redundant tracks #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

FlaShHolloway
Copy link
Contributor

  • --use-cached is opt-in flag to stores the result of search in lookup.json file. Can be used with create, liked, update and all argument.
  • cache-clear argument clears the cache file.
  • search argument is just for testing what algorithm returns (and trust me YouTube doesn't always give the results correctly every time).

Copy link
Owner

@sigma67 sigma67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for extracting this! I have added some comments, main issues from my point of view:

  • caching should be a separate class
  • tests are missing

@FlaShHolloway
Copy link
Contributor Author

@sigma67 do you want me to integrate changes of ruff format?

@sigma67
Copy link
Owner

sigma67 commented Feb 20, 2025

@FlaShHolloway yes, please ensure the formatter and linter pass

@sigma67 sigma67 merged commit 28e3f54 into sigma67:main Feb 20, 2025
2 checks passed
@FlaShHolloway FlaShHolloway deleted the caching branch February 21, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants