Skip to content

Conversation

@romanziske
Copy link
Contributor

This pr finally finished adding the remaining SigMF extensions as JSON schemas.

I also let GPT-o3 refactor the docs-generators, added support for all extension and fixed some bugs (now all links and refs should work).

@777arc
Copy link
Member

777arc commented Jun 23, 2025

Nice!!! According to https://ajv.js.org/guide/schema-language.html#draft-07-and-draft-06 we are probably better with draft 7 like you changed it to. I looked at the compiled_docs.zip that the github action generated, and it looks pretty good.

@gmabey
Copy link
Contributor

gmabey commented Jul 3, 2025

Nice!!! According to https://ajv.js.org/guide/schema-language.html#draft-07-and-draft-06 we are probably better with draft 7 like you changed it to. I looked at the compiled_docs.zip that the github action generated, and it looks pretty good.

I think it was me to initiated the use of draft-2020-12, and I think it might be worth sticking with if someone is actually going to define a type (once) that would be used to setup core:global_index, core:sample_start, core:sample_count, etc.

I attempted to build the docs, but failed on ubuntu 22.04 (ok, I need to upgrade).
Following the README.md, I looked for an artifact for this PR but couldn't see one. Is that something that Roman needs to initiate?

My intent is to review the changes based on those docs, instead of trying to parse these auto-generated changes, which is a great thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants