-
Notifications
You must be signed in to change notification settings - Fork 80
Add an emitter_label string #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Seems reasonable to me, what do you think @jacobagilbert or anyone else |
|
Since
|
|
Just to clarify, you are suggesting that we use "signal"->"emitter"->"label" instead of "signal"->"emitter"->"emitter_label", and not suggesting that we just use "core:label" for the emitter serial number/MAC/callsign/etc, correct? |
f9c6e21 to
21efa25
Compare
Yes, just as you have changed it. |
|
Everyone happy here? Ready to merge? |
|
Is it possible to get this merged in? |
|
Does there need to be any sort of versioning of the signal extension? |
|
That's a good point, none of our extension's schema is versioned yet |
|
Does that block merging this? |
|
Nope, merging =) |
Add a human readable string label for an emitter such as MAC address or an alphanumeric serial number. The seid field is an int.