Skip to content

Conversation

@daltoncass
Copy link
Contributor

Add a human readable string label for an emitter such as MAC address or an alphanumeric serial number. The seid field is an int.

@777arc
Copy link
Member

777arc commented Sep 18, 2025

Seems reasonable to me, what do you think @jacobagilbert or anyone else

@Teque5
Copy link
Collaborator

Teque5 commented Sep 19, 2025

Since emitter is already in the name of the extension, perhaps it should just be label instead. I believe a MAC address would still fall under the description for label we are using in SigMF generally:

A short form human/machine-readable label for the annotation. The label field MAY be used for any purpose, but it is RECOMMENDED that it be limited to no more than 20 characters as a common use is a short form GUI indicator. Similarly, it is RECOMMENDED that any user interface making use of this field be capable of displaying up to 20 characters. type : string

@daltoncass
Copy link
Contributor Author

Just to clarify, you are suggesting that we use "signal"->"emitter"->"label" instead of "signal"->"emitter"->"emitter_label", and not suggesting that we just use "core:label" for the emitter serial number/MAC/callsign/etc, correct?

@daltoncass daltoncass force-pushed the add_emitter_label_string branch from f9c6e21 to 21efa25 Compare September 22, 2025 12:38
@Teque5
Copy link
Collaborator

Teque5 commented Sep 22, 2025

Just to clarify, you are suggesting that we use "signal"->"emitter"->"label" instead of "signal"->"emitter"->"emitter_label", and not suggesting that we just use "core:label" for the emitter serial number/MAC/callsign/etc, correct?

Yes, just as you have changed it.

@Teque5
Copy link
Collaborator

Teque5 commented Sep 25, 2025

Everyone happy here? Ready to merge?

@daltoncass
Copy link
Contributor Author

Is it possible to get this merged in?

@daltoncass
Copy link
Contributor Author

Does there need to be any sort of versioning of the signal extension?

@777arc
Copy link
Member

777arc commented Sep 30, 2025

That's a good point, none of our extension's schema is versioned yet

@daltoncass
Copy link
Contributor Author

Does that block merging this?

@777arc
Copy link
Member

777arc commented Oct 2, 2025

Nope, merging =)

@777arc 777arc merged commit 209b186 into sigmf:main Oct 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants