Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .Values.istio.revision to support Istio control plane revisions #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewjamesbrown
Copy link

@andrewjamesbrown andrewjamesbrown commented Jan 7, 2025

Change description

Support Istio control plane revisions by using the istio.io/rev label on pods when Istio is enabled

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@scott-cotton
Copy link
Member

As this repository is largely automatically generated, incorporating this change would not take the form of a direct merge. However this PR will help a great deal in doing so, so thanks very much!

We're looking into incorporating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants