Override policy changes #221
Conversation
|
Gitar automatically fixes CI failures and addresses comments starting with ⚙️ Options:
🔄 To revert changes, post a comment: * Gitar never force pushes to your branch |
|
I implemented https://signadot.slack.com/archives/C0922R1BJ1L/p1760384469331639 in ec94ccd (plus other minor fixes). |
| to a local service. This is useful for testing local changes in a realistic | ||
| sandbox without redeploying code. | ||
| By default, overrides apply when the response from the target override |
There was a problem hiding this comment.
I would use the term "local service" throughout, for example in place of "target override" here.
| Short: "Override sandbox HTTP traffic using a local service", | ||
| Long: `The 'override' command allows you to route HTTP traffic from a sandbox environment | ||
| to a local service. This is useful for testing local changes in a realistic | ||
| sandbox without redeploying code. |
There was a problem hiding this comment.
I would add a short bit clarifying what "override applies" means. For example, perhaps
Using the 'override' command, when a request comes into the sandbox it is delivered to the local service. The response of the local service determines whether or not the request will subsequently be delivered to its original destination, i.e. to the the sandbox workload. When the request is not subsequently delivered to the original destination, the response from the the local service is the response given back to the request.
When the local service is not running, requests will be delivered to the original destination after failing to communicate with the local service.
There was a problem hiding this comment.
I tried to accommodate this in 5cd6b9f, PTAL.
|
@daniel-de-vera FYI I am working on top of this for the readiness/consistency polling. Let's sync up if you want to make further flow/structural changes to reduce merge conflicts. |
2 participants
This PR: