incorporate session id in renewal endpoint #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-cotton
added a commit
to signadot/cli
that referenced
this pull request
Dec 15, 2025
depends on signadot/signadot#6457 and signadot/go-sdk#76 previously, the api re-claimed on renewal, creating a corner case hole where more than 1 local connect could be running at the same time. Please review signadot/signadot#6457 for details and explanation of the flow and what has been tested. Side Effects This change removed the need for dynamic session id updates. Misc Fixes The check for --cluster was pushed to earlier to avoid the possibility of registering and claiming a devbox and then failing due to a mis-specified cluster.
scott-cotton
added a commit
to signadot/cli
that referenced
this pull request
Dec 15, 2025
* incorporate session id into renewal depends on signadot/signadot#6457 and signadot/go-sdk#76 previously, the api re-claimed on renewal, creating a corner case hole where more than 1 local connect could be running at the same time. Please review signadot/signadot#6457 for details and explanation of the flow and what has been tested. Side Effects This change removed the need for dynamic session id updates. Misc Fixes The check for --cluster was pushed to earlier to avoid the possibility of registering and claiming a devbox and then failing due to a mis-specified cluster. * CR * use merged-to-main new go-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on https://github.com/signadot/signadot/pull/6457