make ui more app real #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Frontend Sandbox Ready! |
Frontend Test Results2 tests 1 ✅ 1s ⏱️ Results for commit d372463. ♻️ This comment has been updated with latest results. |
Contributor
Author
|
@foxish updated to include arriving time |
foxish
approved these changes
Dec 23, 2024
| if (completed) { | ||
| return <Text>{driverName} arrived</Text>; | ||
| } else { | ||
| return <Text as="b">The driver {driverName} will arrive in {minutes.toString().padStart(2, "0")}:{seconds.toString().padStart(2, "0")}</Text>; |
Member
There was a problem hiding this comment.
We also want to put the Driver's Plate (T702061C) here. The message should be:
The driver {driverName} (plate) will arrive in X minutes
foxish
reviewed
Dec 23, 2024
| </Stack> | ||
| <div className={`${styles.drawer} ${logsModal.isOpen ? styles.open : ''}`}> | ||
| <div className={styles.drawerHeader}> | ||
| <Heading size="md">Notifications Logs</Heading> |
Member
There was a problem hiding this comment.
Should just say "logs" and have a margin above. Also, can you make the border between each set of log entries darker?
Currently seems very subtle and hard to see:
Member
|
LGTM, please merge when you're done with your changes and you think it's ready to go |
foxish
added a commit
that referenced
this pull request
Feb 7, 2025
* add air config for handling frontend ui changes * move logs to sidebar and make map live * add instructions for how to use air * add driver arrival and driver name * Update README.md * Update home.tsx * add driver plate * fix spacing and coloring cosmetic --------- Co-authored-by: Anirudh Ramanathan <anirudh@foxish.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Screen.Recording.2024-12-13.at.3.29.38.PM.mov