-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E - Fix cypress not running new UI #257
base: main
Are you sure you want to change the base?
Conversation
@daniel-de-vera - can you verify that this fixes the issue? code LGTM otherwise. |
As far as I can see, it is still failing (this is against staging, the sandbox is pointing to signadot job submit --attach -f .signadot/testing/demo-tests-job.yaml --set sandbox=hotrod-pr-256-frontend --set branch=fix-cypress-test-run --set namespace=hotrod-istio Result: https://app.staging.signadot.com/testing/jobs/hotrod-cypress-demo-srqdgdq/logs |
I'm looking into this now - it appears the frontend that it's running against in hotrod:latest is not the actual latest version of the frontend. Trying to understand why this might happen. |
@daniel-de-vera - this succeeds once I replaced the baseline in hotrod-istio fully with signadot/hotrod:latest. Looks like the https://app.staging.signadot.com/testing/jobs/hotrod-cypress-demo-fwcsfky/overview |
Mmm, but in the example from above I was running in a sandbox (hotrod-pr-256-frontend) that had |
// require('./commands') | ||
|
||
Cypress.on('uncaught:exception', (err, runnable) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to prevent cypress failing the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after comments
No description provided.