Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E - Fix cypress not running new UI #257

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

davixcky
Copy link
Contributor

No description provided.

@davixcky davixcky requested a review from foxish January 15, 2025 03:46
@davixcky davixcky changed the title E2E - Fix cypress not running new UI) E2E - Fix cypress not running new UI Jan 15, 2025
@foxish foxish requested a review from daniel-de-vera January 15, 2025 15:52
@foxish
Copy link
Member

foxish commented Jan 15, 2025

@daniel-de-vera - can you verify that this fixes the issue? code LGTM otherwise.

@daniel-de-vera
Copy link
Contributor

As far as I can see, it is still failing (this is against staging, the sandbox is pointing to hotrod:latest):

signadot job submit --attach -f .signadot/testing/demo-tests-job.yaml --set sandbox=hotrod-pr-256-frontend --set branch=fix-cypress-test-run --set namespace=hotrod-istio

Result:

https://app.staging.signadot.com/testing/jobs/hotrod-cypress-demo-srqdgdq/logs

@foxish foxish added the istio label Jan 15, 2025
@foxish foxish closed this Jan 15, 2025
@foxish foxish reopened this Jan 15, 2025
@foxish
Copy link
Member

foxish commented Jan 15, 2025

I'm looking into this now - it appears the frontend that it's running against in hotrod:latest is not the actual latest version of the frontend. Trying to understand why this might happen.

@foxish
Copy link
Member

foxish commented Jan 16, 2025

@daniel-de-vera - this succeeds once I replaced the baseline in hotrod-istio fully with signadot/hotrod:latest. Looks like the e2e-v2.9 and the latest are not compatible with one another.

https://app.staging.signadot.com/testing/jobs/hotrod-cypress-demo-fwcsfky/overview

@daniel-de-vera
Copy link
Contributor

@daniel-de-vera - this succeeds once I replaced the baseline in hotrod-istio fully with signadot/hotrod:latest. Looks like the e2e-v2.9 and the latest are not compatible with one another.

https://app.staging.signadot.com/testing/jobs/hotrod-cypress-demo-fwcsfky/overview

Mmm, but in the example from above I was running in a sandbox (hotrod-pr-256-frontend) that had signadot/hotrod:latest as the image. Will check further.

// require('./commands')

Cypress.on('uncaught:exception', (err, runnable) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to prevent cypress failing the test?

Copy link
Member

@foxish foxish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants