E2E - Fix cypress not running new UI #257
Conversation
davixcky
changed the title
|
@daniel-de-vera - can you verify that this fixes the issue? code LGTM otherwise. |
|
As far as I can see, it is still failing (this is against staging, the sandbox is pointing to signadot job submit --attach -f .signadot/testing/demo-tests-job.yaml --set sandbox=hotrod-pr-256-frontend --set branch=fix-cypress-test-run --set namespace=hotrod-istioResult: https://app.staging.signadot.com/testing/jobs/hotrod-cypress-demo-srqdgdq/logs |
|
I'm looking into this now - it appears the frontend that it's running against in hotrod:latest is not the actual latest version of the frontend. Trying to understand why this might happen. |
|
@daniel-de-vera - this succeeds once I replaced the baseline in hotrod-istio fully with signadot/hotrod:latest. Looks like the https://app.staging.signadot.com/testing/jobs/hotrod-cypress-demo-fwcsfky/overview |
Mmm, but in the example from above I was running in a sandbox (hotrod-pr-256-frontend) that had |
| // require('./commands') No newline at end of file | ||
| // require('./commands') | ||
|
|
||
| Cypress.on('uncaught:exception', (err, runnable) => { |
There was a problem hiding this comment.
Why do we want to prevent cypress failing the test?
* fix contain and other issues to remediate cypress run * test path matcher that is wider * Delete cypress/e2e/hotrod-e2e.cy.js --------- Co-authored-by: Anirudh Ramanathan <anirudh@signadot.com> Co-authored-by: Anirudh Ramanathan <anirudh@foxish.me>
No description provided.