Skip to content

[Location] Make breaking change to response fields in location service #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Location] Make breaking change to response fields in location service #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions services/location/database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,27 +56,27 @@ CREATE TABLE IF NOT EXISTS locations
var seed = []Location{
{
ID: 1,
Name: "My Home",
LocName: "My Home",
Coordinates: "231,773",
},
{
ID: 123,
Name: "Rachel's Floral Designs",
LocName: "Rachel's Floral Designs",
Coordinates: "115,277",
},
{
ID: 567,
Name: "Amazing Coffee Roasters",
LocName: "Amazing Coffee Roasters",
Coordinates: "211,653",
},
{
ID: 392,
Name: "Trom Chocolatier",
LocName: "Trom Chocolatier",
Coordinates: "577,322",
},
{
ID: 731,
Name: "Japanese Desserts",
LocName: "Japanese Desserts",
Coordinates: "728,326",
},
}
Expand Down Expand Up @@ -154,7 +154,7 @@ func (d *database) List(ctx context.Context) ([]Location, error) {
var cs []Location
for rows.Next() {
c := Location{}
if err := rows.Scan(&c.ID, &c.Name, &c.Coordinates); err != nil {
if err := rows.Scan(&c.ID, &c.LocName, &c.Coordinates); err != nil {
return nil, err
}
cs = append(cs, c)
Expand All @@ -168,12 +168,12 @@ func (d *database) List(ctx context.Context) ([]Location, error) {

func (d *database) Create(ctx context.Context, location *Location) (int64, error) {
query := "INSERT INTO locations SET name = ?, coordinates = ?"
res, err := d.db.Exec(query, location.Name, location.Coordinates)
res, err := d.db.Exec(query, location.LocName, location.Coordinates)
if err != nil {
if !d.shouldRetry(err) {
return 0, err
}
res, err = d.db.Exec(query, location.Name, location.Coordinates)
res, err = d.db.Exec(query, location.LocName, location.Coordinates)
if err != nil {
return 0, err
}
Expand All @@ -187,12 +187,12 @@ func (d *database) Create(ctx context.Context, location *Location) (int64, error

func (d *database) Update(ctx context.Context, location *Location) error {
query := "UPDATE locations SET name = ?, coordinates = ? WHERE id = ?"
res, err := d.db.Exec(query, location.Name, location.Coordinates, location.ID)
res, err := d.db.Exec(query, location.LocName, location.Coordinates, location.ID)
if err != nil {
if !d.shouldRetry(err) {
return err
}
res, err = d.db.Exec(query, location.Name, location.Coordinates, location.ID)
res, err = d.db.Exec(query, location.LocName, location.Coordinates, location.ID)
if err != nil {
return err
}
Expand Down Expand Up @@ -240,7 +240,7 @@ func (d *database) Get(ctx context.Context, locationID int) (*Location, error) {
return nil, row.Err()
}
}
if err := row.Scan(&c.ID, &c.Name, &c.Coordinates); err != nil {
if err := row.Scan(&c.ID, &c.LocName, &c.Coordinates); err != nil {
return nil, err
}
return &c, nil
Expand Down Expand Up @@ -285,7 +285,7 @@ func (d *database) setupDB() {
}
for i := range seed {
c := &seed[i]
if _, err := stmt.Exec(c.ID, c.Name, c.Coordinates); err != nil {
if _, err := stmt.Exec(c.ID, c.LocName, c.Coordinates); err != nil {
panic(err)
}
}
Expand Down
2 changes: 1 addition & 1 deletion services/location/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
// Location contains data about a location.
type Location struct {
ID int64 `json:"id"`
Name string `json:"name"`
LocName string `json:"locName"`
Coordinates string `json:"coordinates"`
}

Expand Down
Loading