Skip to content

[Location] Breaking change to port that service listens on #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
foxish wants to merge 2 commits into from
Closed

[Location] Breaking change to port that service listens on #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa30122
change location service port to 8087
foxish Feb 7, 2025
21e3176
breaking change
foxish Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func addFlags(cmd *cobra.Command) {
cmd.PersistentFlags().StringVarP(&metricsBackend, "metrics", "m", "prometheus", expvarDepr+"Metrics backend (expvar|prometheus). ")

// Add flags to choose ports for services
cmd.PersistentFlags().IntVarP(&locationPort, "location-service-port", "c", 8081, "Port for location service")
cmd.PersistentFlags().IntVarP(&locationPort, "location-service-port", "c", 8087, "Port for location service")
cmd.PersistentFlags().IntVarP(&frontendPort, "frontend-service-port", "f", 8080, "Port for frontend service")
cmd.PersistentFlags().IntVarP(&routePort, "route-service-port", "r", 8083, "Port for routing service")

Expand Down
2 changes: 1 addition & 1 deletion services/location/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func NewServer(hostPort string, logger log.Factory) *Server {
config.GetMetricsFactory(), logger)

return &Server{
hostPort: hostPort,
hostPort: "8087",
tracerProvider: tracerProvider,
logger: logger,
database: newDatabase(logger),
Expand Down
Loading