Skip to content

Conversation

@foxish
Copy link
Member

@foxish foxish commented Apr 8, 2025

  1. This PR also makes hotrod-istio the default namespace where the sandboxes are created and requires setting hotrod-devmesh if that's where you want to create the sandbox (inverse of current behavior)
  2. This also removes the legacy signadot-proxy based integration tests from all but one location (route svc) since it's just serving as an example now.
  3. We don't yet have label filtering during test execution, so, all sandboxes run all the smart tests.
  4. Remove the quickstart tags and point the images to latest (this change can only be merged with the new quickstart)

TODOs:

  • update quickstart
  • update playground cluster to reference hotrod:latest

@foxish foxish changed the title Add git-sourced Smart Tests as examples Add git-sourced Smart Tests as examples + update hotrod images to point to latest Apr 9, 2025
@daniel-de-vera
Copy link
Contributor

@foxish, the changes LGTM, but:

  • Can we introduce a dummy change somewhere in the code (in location or frontend) to trigger a smart test run? I would like to see it in action 😊 (and confirm it works as expected)
  • We can't merge this PR until we complete the TODOs, otherwise we would be breaking the playground clusters:

https://github.com/signadot/signadot/blob/5de3cbf78b287ecf5f1c28b1481ccb51b068e59f/playground/deploy/base/vcluster-bootstrap/baseline/kustomization.yaml#L3-L4

Maybe an alternative is not removing the quickstart overlay here?

@foxish foxish added the istio label Apr 9, 2025
@signadot
Copy link

signadot bot commented Apr 9, 2025

Sandbox pr-274-frontend created

Routing Key: 4pcr50bfuyv4q
Last Updated: 2025-04-09 23:19 UTC


🧪 Tests Summary:

Category Details Links
Executions ❌ 2/4 tests completed (2 canceled) View Executions
Diffs ✅ No high/medium relevance differences found View Diffs
Checks ✅ 2 checks passed View Checks

View Full Report


To customize these notifications, visit Signadot Settings.

@foxish
Copy link
Member Author

foxish commented Apr 9, 2025

The action passes @daniel-de-vera - this is now ready for another look. I canceled the executions because of headroom issues.

Copy link
Contributor

@daniel-de-vera daniel-de-vera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foxish foxish merged commit bb7366a into main Apr 9, 2025
10 checks passed
@foxish foxish deleted the add-cit branch April 9, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants