-
Notifications
You must be signed in to change notification settings - Fork 10
Configuration Reorg #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Reorg #284
Conversation
@scott-cotton, if this gets approved, I would tag a new version for e2e tests.. WDYT? |
Sandbox pr-284-route createdRouting Key: 🧪 Tests Summary:
To customize these notifications, visit Signadot Settings. |
Certainly at some point. Does that require modifying the e2es? I guess the |
No, I don't think so (but I didn't test it to confirm it). |
Would it be reasonably possible to replace
If so, I think that would be more natural. wdyt? |
I'm not sure I fully got your proposal, can you expand? (fyi, I tried several approaches, I really wanted to solve this within Kustomize, but the only solution I found was using Also, one problem I did face was that when you use |
Did you try to use k8s dependent env vars? |
Oh, great, that looks exactly what I needed. I will try it 😊 |
@scott-cotton, check this out: $ eval "$(signadot sandbox get-env local-hotrod-location)"
SIGNADOT_BASELINE_NAMESPACE: command not found
SIGNADOT_BASELINE_NAMESPACE: command not found
SIGNADOT_BASELINE_NAMESPACE: command not found
$ signadot sandbox get-env local-hotrod-location
export SIGNADOT_BASELINE_KIND="Deployment" # constant
export SIGNADOT_BASELINE_NAMESPACE="hotrod-dev-istio" # fieldRef: metadata.namespace
export SIGNADOT_BASELINE_NAME="location" # constant
export MYSQL_ADDR="mysql.$(SIGNADOT_BASELINE_NAMESPACE):3306" # constant
export MYSQL_PASS="abc" # constant
export REDIS_ADDR="redis.$(SIGNADOT_BASELINE_NAMESPACE):6379" # constant
export OTEL_EXPORTER_OTLP_ENDPOINT="http://jaeger.$(SIGNADOT_BASELINE_NAMESPACE):4318" # constant
export SIGNADOT_SANDBOX_NAME="local-hotrod-location" # constant (override)
export SIGNADOT_SANDBOX_ROUTING_KEY="d3gbpykjdpy5u" # constant (override) So, basically we can't use this approach because our CLI does not supports dependent variable 😔🤦 |
Surprising, I would have thought that k8s would have resolved that for the pods. Not sure why they don't. |
Did you fix the CLI/libconnect, hotrod, or both? |
No, just hotrod. I didn't touch the CLI (I guess we should create an issue for this). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR reorganizes the configuration of the HotROD services to make them easier to use in the context of local Signadot sandboxes. Specifically, it: