Skip to content

Conversation

foxish
Copy link
Member

@foxish foxish commented Apr 18, 2023

Adds real mariadb and deployment

@foxish foxish requested a review from scott-cotton April 18, 2023 05:52
@foxish foxish requested a review from daniel-de-vera May 30, 2023 13:26
@daniel-de-vera
Copy link

I would be nice to integrate the deployment of the helm-manifests with skaffold (let skaffold take care of installing those helm charts).
If not, at least update README.md and set running ./helm-manifests/deploy.sh as a prerequisite.

@daniel-de-vera
Copy link

In README.md we have:

- **Minikube** requires you to run a command to access the frontend service:
```shell
minikube service frontend-external

But the frontend-external service is commented out:

#apiVersion: v1
#kind: Service
#metadata:
# name: frontend-external
#spec:
# type: LoadBalancer
# selector:
# app: frontend
# ports:
# - name: http
# port: 80
# targetPort: 8080

@daniel-de-vera
Copy link

daniel-de-vera commented May 30, 2023

These two files are not in-sync with the plugin itself:

plugins/mariadb/README.md
plugins/mariadb/example-sandbox.yaml

IMO, we should either update or remove them.
I would also rename the base directory from plugins/mariadb to plugins/productcatalog-mariadb

@daniel-de-vera
Copy link

Should we include a script or some documentation about how to deploy this in our demo cluster?

@foxish
Copy link
Member Author

foxish commented Jul 10, 2023

I would be nice to integrate the deployment of the helm-manifests with skaffold (let skaffold take care of installing those helm charts).

I'll try to simplify this so helm is not needed, else it adds another dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants