Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Video Mode for CameraXFragment #13935

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sagar0-0
Copy link
Contributor

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

  1. The new MediaMode (currently textStoryToggleMode) has 3 Mode { VIDEO, CAMERA, TEXT }.
  2. The HugCommand has a new GoToVideo command.
  3. To update the State properly, All GoToX HudCommands are handled in the MediaSelectionActivity.
  4. A new VideoCameraButtonView is created to handle video button view independently

HELP:

  1. For Camera1Fragment, I am not sure what is the recommended way to hide the video tab, simply put it in an if statement.

Problem/Bugs:
After testing, I have encountered further issues:

  1. User can press on the gallery while recording.
  2. User can change the MediaMode while recording.
  3. User can press back while recording.
    These issues are fixed in my last PR Video recording improvements #13933
  4. The CameraFragment is destroyed and recreated every time when we come back from TextStoryFragment, this can be prevented. (This already existed but is not introduced in this change).

Improvements:

  1. VideoCameraButtonView can be improved, open for suggestions.

@Sagar0-0 Sagar0-0 mentioned this pull request Jan 23, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant